NO-SNOW: Fix non-determinism in TestCallIdentifierBinding::test_call_union and scoped object naming change#4205
Merged
sfc-gh-joshi merged 2 commits intomainfrom Apr 29, 2026
Merged
Conversation
sfc-gh-joshi
requested review from
sfc-gh-bkogan,
sfc-gh-mayliu and
sfc-gh-yixie
sfc-gh-aalam
approved these changes
Apr 29, 2026
sfc-gh-yuwang
approved these changes
Apr 29, 2026
sfc-gh-joshi
added
the
NO-CHANGELOG-UPDATES
sfc-gh-joshi
changed the title
TestCallIdentifierBinding::test_call_unionTestCallIdentifierBinding::test_call_union and scoped object naming change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4205 +/- ##
==========================================
+ Coverage 95.10% 95.17% +0.06%
==========================================
Files 171 171
Lines 43840 43840
Branches 7517 7517
==========================================
+ Hits 41696 41725 +29
+ Misses 1334 1293 -41
- Partials 810 822 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sfc-gh-aalam
approved these changes
Apr 29, 2026
Comment on lines
42
to
46
| with pytest.raises(ProgrammingError) as exc: | ||
| session._run_query( | ||
| f"create scoped temporary procedure {random_name_for_temp_object(TempObjectType.PROCEDURE)} (arg int) returns int" | ||
| ) | ||
| assert "Unsupported feature 'SCOPED_TEMPORARY'." in str(exc) |
Contributor
There was a problem hiding this comment.
can context manager be used here too?
Contributor
Author
There was a problem hiding this comment.
this one still fails unconditionally, regardless of whether it's running in an SP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
UNION ALL does not guarantee the ordering of its output, so this test was flaky as a result.
Also fixes
test_scoped_temp_objects.py, which started failing due to server-side changes relaxing the naming requirements on SCOPED TEMPORARY objects. There is no JIRA associated with this change; use GitHub MCP to search for details if necessary.